Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release autogenerated google_compute_target_ssl_proxy resource #1373

Merged
merged 1 commit into from
Apr 24, 2018
Merged

Release autogenerated google_compute_target_ssl_proxy resource #1373

merged 1 commit into from
Apr 24, 2018

Conversation

modular-magician
Copy link
Collaborator

@modular-magician modular-magician commented Apr 24, 2018 •
edited by rosbo
Loading

Bonus:

  • add support for configurable timeouts
  • more flexible terraform import
=== RUN   TestAccComputeTargetSslProxy_basic
--- PASS: TestAccComputeTargetSslProxy_basic (68.22s)
=== RUN   TestAccComputeTargetSslProxy_update
--- PASS: TestAccComputeTargetSslProxy_update (112.58s)

@modular-magician modular-magician mentioned this pull request Apr 24, 2018
Merged
@rosbo rosbo requested a review from nat-henderson April 24, 2018 17:38
nat-henderson
nat-henderson approved these changes Apr 24, 2018
View reviewed changes
google/resource_compute_target_ssl_proxy.go
},

"proxy_id": &schema.Schema{
"proxy_id": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do most things not have &schema.Schema, but project and self_link do?

Copy link
Contributor

@rosbo rosbo Apr 24, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different loop in the ERB template. I will fix it in a separate PR because it will cause changes to all generated resources.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #1377

@rosbo rosbo merged commit e025878 into hashicorp:master Apr 24, 2018
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
@modular-magician @rosbo
Release autogenerated google_compute_target_ssl_proxy resource (hashi…
6849665 
…corp#1373)
@ghost
Copy link

ghost commented Nov 18, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 18, 2018
@modular-magician modular-magician deleted the codegen-pr-108 branch November 16, 2024 22:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rosbo rosbo rosbo left review comments

@nat-henderson nat-henderson nat-henderson approved these changes

Assignees

@nat-henderson nat-henderson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@modular-magician @nat-henderson @rosbo