Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct Project ID regex in instanceGroupManagerURL #1311

Merged

Conversation

beaglebot
Copy link
Contributor

Attempting to create a GKE cluster with a (valid) project ID containing a ':' results in the following error:

Error reading instance group manage URL '"https://www.googleapis.com/compute/v1/projects/example.io:example/zones/us-central1-a/instanceGroupManagers/gke-example-product-terraform-201804-4f57f12f-grp"'

This error is raised here, and caused by an overly restrictive project regex here.

The correct project ID regex is already defined in the repo here.

This PR updates the instanceGroupManagerURL regex to use the existing ProjectRegex.

@rosbo
Copy link
Contributor

rosbo commented Apr 10, 2018

Thanks @beaglebot for this contribution. Merging

@rosbo rosbo merged commit 1c992ab into hashicorp:master Apr 10, 2018
@ghost
Copy link

ghost commented Nov 19, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants