Updates container_cluster to set enable_legacy_abac to false by default #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danawillow
reviewed
Apr 3, 2018
| Config: testAccContainerCluster_defaultLegacyAbac(acctest.RandString(10)), | ||
| Check: resource.ComposeTestCheckFunc( | ||
| resource.TestCheckResourceAttr("google_container_cluster.default_legacy_abac", "enable_legacy_abac", "false"), | ||
| ), |
There was a problem hiding this comment.
Mind adding an import step here as well? (Take a look at the other tests in this file for examples)
|
@danawillow I addressed your comment. |
|
Thanks a bunch! |
chrisst
pushed a commit
to chrisst/terraform-provider-google
that referenced
this pull request
Nov 9, 2018
…lt (hashicorp#1281) * Updates the default GKE legacy ABAC setting to false * Updates docs for container_cluster * Update test comments * Format fix * Adds ImportState test step to default legacy ABAC test
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion in #1116.
GKE disables legacy ABAC by default in 1.8, and the current default GKE version (as of opening this PR) is 1.8.8. This means that creating a GKE cluster using the cloud console and leaving all values as default will result legacy ABAC being disabled, but creating a GKE cluster using Terraform and leaving all values as default will keep it enabled. This PR disables legacy ABAC by default so the default behavior is more consistent with the cloud console.
Test: