Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix panic when setting empty iap block #1232

Merged
merged 1 commit into from
Mar 20, 2018

Conversation

danawillow
Copy link
Contributor

Fixes #1231

@danawillow danawillow requested a review from paddycarver March 20, 2018 22:30
Copy link
Contributor

@paddycarver paddycarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally this would come with a test that exercised the panic, but I'm not going to block it on that.

@danawillow
Copy link
Contributor Author

I don't want to set a precedent for that- already this is a super weird case, and if we added tests for every potential empty block we would end up with a huge number of tests.

However, if you really wanted one I would happily review the PR :)

@danawillow danawillow merged commit ddfb7ef into hashicorp:master Mar 20, 2018
@danawillow danawillow deleted the is-1231 branch March 20, 2018 22:42
@paddycarver
Copy link
Contributor

I'm in alignment with you on that one :)

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: interface conversion: interface {} is nil, not map[string]interface {}
2 participants