Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support connection_draining_timeout_sec in google_compute_region_backend_service #101

Conversation

rileykarson
Copy link
Collaborator

Added connection_draining_timeout_sec support to google_compute_region_backend_service.

Regional equivalent to hashicorp/terraform#14559
Part 2/2 for #85
@danawillow

),
},
},
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regular backend service tests do a final check here that connection draining went back to 0, want to add that to this one too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@danawillow
Copy link
Contributor

TF_ACC=1 go test ./google -v -run=TestAccComputeRegionBackendService -timeout 120m
=== RUN   TestAccComputeRegionBackendService_basic
--- PASS: TestAccComputeRegionBackendService_basic (74.30s)
=== RUN   TestAccComputeRegionBackendService_withBackend
--- PASS: TestAccComputeRegionBackendService_withBackend (120.03s)
=== RUN   TestAccComputeRegionBackendService_withBackendAndUpdate
--- PASS: TestAccComputeRegionBackendService_withBackendAndUpdate (149.94s)
=== RUN   TestAccComputeRegionBackendService_withConnectionDraining
--- PASS: TestAccComputeRegionBackendService_withConnectionDraining (48.62s)
=== RUN   TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate
--- PASS: TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate (64.03s)
=== RUN   TestAccComputeRegionBackendService_withSessionAffinity
--- PASS: TestAccComputeRegionBackendService_withSessionAffinity (49.34s)
PASS

@danawillow danawillow merged commit deca31e into hashicorp:master Jun 16, 2017
@dgolja
Copy link

dgolja commented Jun 26, 2017

I assume this will be released in the 1.0.0 version ?

@rileykarson
Copy link
Collaborator Author

I'm not sure what version number is going to be used for the provider plugin, but this should be present in the first release!

pdecat pushed a commit to pdecat/terraform-provider-google that referenced this pull request Jun 29, 2017
…-service-connection-draining

Support connection_draining_timeout_sec  in google_compute_region_backend_service
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
…-service-connection-draining

Support connection_draining_timeout_sec  in google_compute_region_backend_service
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants