PostgreSQL high availability #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull in updates to the generated sqladmin api and update callers for the change in the StorageAutoResize setting
Allow specifying ZONAL or REGIONAL to allow for PostgreSQL HA setup.
|
Hey @danawillow, this PR should cover the comments you made on #695. Can you give this a second pass please? |
danawillow
reviewed
Jan 24, 2018
| @@ -568,7 +606,7 @@ func testAccCheckGoogleSqlDatabaseInstanceEquals(n string, | |||
| return fmt.Errorf("Error settings.crash_safe_replication mismatch, (%s, %s)", server, local) | |||
| } | |||
|
|
|||
| server = strconv.FormatBool(instance.Settings.StorageAutoResize) | |||
| server = strconv.FormatBool(*instance.Settings.StorageAutoResize) | |||
There was a problem hiding this comment.
I'm seeing panics at this line when running tests, can you check it out?
There was a problem hiding this comment.
Having a look at this now- do you have the test that caused the fatal? Would speed up things on my end, as the few I've been running do not!
There was a problem hiding this comment.
Think I've got a fix for this, will update the PR once I've confirmed tests pass.
Add tests that cover the creation of a Postgres database with AvailabilityType set to REGIONAL, and correct some small issues that were preventing compilation.
lawrencejones
force-pushed
the
lawrence-postgresql-ha
branch
from
24e27cc to
9c895d3
Compare
googleapis/google-api-go-client@95e5582 The cloudsql admin client changed the way it handles StorageAutoResize as a parameter, in order to be more explicit about when the server has ommitted the field. This changed the type from being bool to *bool, and we need to modify provider code so that we supply the right value to the api client.
lawrencejones
force-pushed
the
lawrence-postgresql-ha
branch
from
9c895d3 to
3faf55a
Compare
|
Looking a lot healthier this time around: |
|
Looks good, thanks! |
This was referenced Jan 26, 2018
chrisst
pushed a commit
to chrisst/terraform-provider-google
that referenced
this pull request
Nov 9, 2018
* Update sqladmin api Pull in updates to the generated sqladmin api and update callers for the change in the StorageAutoResize setting * Add support for availability_type setting Allow specifying ZONAL or REGIONAL to allow for PostgreSQL HA setup. * vendor: update sqladmin/v1beta4 * Test setting AvailabilityType for PostgreSQL Add tests that cover the creation of a Postgres database with AvailabilityType set to REGIONAL, and correct some small issues that were preventing compilation. * Fix breaking change w/ disk_autoresize in cloudsql googleapis/google-api-go-client@95e5582 The cloudsql admin client changed the way it handles StorageAutoResize as a parameter, in order to be more explicit about when the server has ommitted the field. This changed the type from being bool to *bool, and we need to modify provider code so that we supply the right value to the api client.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all,
This change continues on from #695 to address the review comments there and finish off the high availability support.
The only changes from #695 are the addition of an integration test and some fixing up of the sqladmin package. Also added some comments to clarify that the 1st Gen instances will required diff suppressing, and a default is provided server side when availability zone isn't given.
@katzj, I hope you don't mind but we really needed this at GoCardless a few months back!
Integration test output is: