Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring to use the new authentication package #54

Merged
merged 16 commits into from
Nov 26, 2018

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Nov 19, 2018

Once this is merged we should be able to add the documentation for Client Certificate authentication for both AzureRM and Azure Stack, and then flip on the feature-toggle

@ghost ghost added the size/XXL label Nov 19, 2018
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte added this to the 0.5.0 milestone Nov 20, 2018
@tombuildsstuff tombuildsstuff changed the title [WIP] Refactoring to use the new authentication package Refactoring to use the new authentication package Nov 26, 2018
@tombuildsstuff
Copy link
Contributor Author

Tests look good:

$ acctests azurestack TestAccAzureStackResourceGroup_basic

=== RUN   TestAccAzureStackResourceGroup_basic
--- PASS: TestAccAzureStackResourceGroup_basic (61.22s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurestack/azurestack	61.646s

Provider seems fine in testing 👍

@tombuildsstuff tombuildsstuff merged commit 680e16a into master Nov 26, 2018
@tombuildsstuff tombuildsstuff deleted the f/refactor-auth branch November 26, 2018 08:35
tombuildsstuff added a commit that referenced this pull request Nov 26, 2018
@ghost
Copy link

ghost commented Jun 27, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants