Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] azurerm_hdinsight_hadoop_cluster - Add edge node support #4049

Closed
wants to merge 13 commits into from
Closed

[WIP] azurerm_hdinsight_hadoop_cluster - Add edge node support #4049

wants to merge 13 commits into from

Conversation

mbfrahry
Copy link
Member

@mbfrahry mbfrahry commented Aug 9, 2019

No description provided.

@ghost ghost added the size/L label Aug 9, 2019
@ghost ghost added size/XL and removed size/L labels Aug 9, 2019
katbyte
katbyte reviewed Aug 10, 2019
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from missing docs LGTM 👍

azurerm/resource_arm_hdinsight_hadoop_cluster.go Outdated
@@ -2,6 +2,7 @@ package azurerm

import (
"fmt"
"github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/validate"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we sort the imports here?

@ghost ghost added the documentation label Aug 21, 2019
@mbfrahry mbfrahry added service/hdinsight upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR labels Sep 3, 2019
@mbfrahry mbfrahry added this to the Blocked milestone Sep 3, 2019
@mbfrahry
Copy link
Member Author

mbfrahry commented Sep 3, 2019

Blocked waiting on Azure/go-autorest#464

@tombuildsstuff
Copy link
Contributor

Rather than leaving this open without a resolution - I'm gonna close this until Azure/go-autorest#464 is resolved - once Azure/go-autorest#464 has been resolved we can re-open this and take another look

@dintskirveli dintskirveli mentioned this pull request Oct 7, 2019
Merged
@mbfrahry mbfrahry deleted the e-hadoop-cluster-edge-node branch November 19, 2019 02:21
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte left review comments

Assignees
No one assigned
Labels
documentation hashibot/ignore service/hdinsight size/XL upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Projects
None yet
Milestone
Blocked
Development

Successfully merging this pull request may close these issues.
3 participants
@mbfrahry @tombuildsstuff @katbyte