Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streamanalytics version upgrade: 2016-03-01 -> 2020-03-01-preview #12133

Merged
merged 1 commit into from
Jun 10, 2021
Merged

streamanalytics version upgrade: 2016-03-01 -> 2020-03-01-preview #12133

merged 1 commit into from
Jun 10, 2021

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Jun 9, 2021

This PR is to upgrade the API version from 2016-03-01 to 2017-04-01-preview for the streamanalytics. The main reason is that the feature requested by #12096 is introduced since 2017-04-01-preview.

@ghost ghost added size/XXL labels Jun 9, 2021
@magodo
Copy link
Collaborator Author

magodo commented Jun 9, 2021

image

@jackofallops
Copy link
Member

Hi @magodo - The PR Title/Description and the version update in the change don't match, can you check which is correct and update accordingly? Thanks!

@katbyte katbyte changed the title streamanalytics version upgrade: 2016-03-01 -> 2017-04-01-preview streamanalytics version upgrade: 2016-03-01 -> 2020-03-01-preview Jun 10, 2021
katbyte
katbyte approved these changes Jun 10, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @magodo - LGTM 🤖 updated title to the API you've actlally used.

@katbyte katbyte added this to the v2.63.0 milestone Jun 10, 2021
@katbyte katbyte merged commit bc7525e into hashicorp:master Jun 10, 2021
katbyte added a commit that referenced this pull request Jun 10, 2021
@katbyte
CHANGELOG.md for #12133
cf735ad
@magodo
Copy link
Collaborator Author

magodo commented Jun 11, 2021

@katbyte and @jackofallops Sorry for missing this comment. Though the package is named 2020-03-01, the API version used underlying is actually 2017-04-01-preview:

https://github.com/terraform-providers/terraform-provider-azurerm/pull/12133/files#diff-e1bf104cbb131fedf0daa1d03e6c6d507630d437c0c14e959fc95daa6412fc87R88

@ghost
Copy link

ghost commented Jun 11, 2021

This has been released in version 2.63.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.63.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
dependencies service/stream-analytics size/XXL waiting-response
Projects
None yet
Milestone
v2.63.0
Development

Successfully merging this pull request may close these issues.
3 participants
@magodo @jackofallops @katbyte