-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource: azurerm_media_content_key_policy
#9971
New resource: azurerm_media_content_key_policy
#9971
Conversation
…form-provider-azurerm into azurerm_media_content_key_policy
…form-provider-azurerm into azurerm_media_content_key_policy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @jcanizalez
Thanks for this PR - apologies for the delayed review here!
Taking a look through on the whole this is looking pretty good, if we can fix up the comments then we should be able to take another look and get this merged :)
Thanks!
azurerm/internal/services/media/media_content_key_policy_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/media/media_content_key_policy_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/media/media_content_key_policy_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/media/media_content_key_policy_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/media/media_content_key_policy_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/media/media_content_key_policy_resource_test.go
Outdated
Show resolved
Hide resolved
hey @tombuildsstuff thank you for your review. I applied your suggestions so you can take a look again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @jcanizalez
Thanks for pushing those changes - having taken a look through the commits I've spotted one thing but this otherwise looks good to me 👍
Thanks!
hi @tombuildsstuff I applied you suggestion, so you can check it again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jcanizalez - LGTM 💯
This has been released in version 2.44.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.44.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Hi there introducing the support for new resource azurerm_media_content_key_policy. This PR resolves #9863
Checked: