Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/log_analytics_workspace: force-upgrading the resource id's #9853

Merged
merged 2 commits into from
Dec 16, 2020

Conversation

tombuildsstuff
Copy link
Contributor

This works around an issue in the legacy state migration where the field
resource_group was used in place of resource_group_name. Whilst we
can't re-run the state migration from V0 -> V1 since those resources have
been upgraded - we can duplicate it for V1 -> V2, and patch it for new users
meaning this should work in both scenarios.

Fixes #9790

This works around an issue in the legacy state migration where the field
`resource_group` was used in place of `resource_group_name`. Whilst we
can't re-run the state migration from V0 -> V1 since those resources have
been upgraded - we can duplicate it for V1 -> V2, and patch it for new users
meaning this should work in both scenarios.
@tombuildsstuff tombuildsstuff added this to the v2.41.0 milestone Dec 14, 2020
@tombuildsstuff tombuildsstuff requested a review from a team December 14, 2020 10:23
@ghost ghost added the size/L label Dec 14, 2020
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one trivial observation, but otherwise LGTM 👍

@tombuildsstuff
Copy link
Contributor Author

Running a subset of the tests these look good:

Screenshot 2020-12-16 at 11 28 30

@tombuildsstuff tombuildsstuff merged commit 0174958 into master Dec 16, 2020
@tombuildsstuff tombuildsstuff deleted the b/log-analytics-workspace-state-migration branch December 16, 2020 10:29
tombuildsstuff added a commit that referenced this pull request Dec 16, 2020
@ghost
Copy link

ghost commented Dec 17, 2020

This has been released in version 2.41.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.41.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jan 15, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants