Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurem_sql_elasticpool - fixing a crash where location isn't returned for legacy resources #982

Merged
merged 1 commit into from
Mar 15, 2018

Conversation

tombuildsstuff
Copy link
Contributor

Fixes #678

@tombuildsstuff tombuildsstuff added crash service/mssql Microsoft SQL Server labels Mar 15, 2018
@tombuildsstuff tombuildsstuff added this to the 1.3.0 milestone Mar 15, 2018
@tombuildsstuff tombuildsstuff requested a review from a team March 15, 2018 12:23
@tombuildsstuff tombuildsstuff changed the title Hqndling the location being nil for legacy resources Handling the location being nil for legacy resources Mar 15, 2018
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lGTM

@tombuildsstuff tombuildsstuff changed the title Handling the location being nil for legacy resources azurem_sql_elasticpool - fixing a crash where location isn't returned for legacy resources Mar 15, 2018
@tombuildsstuff tombuildsstuff merged commit 3a5a6e6 into master Mar 15, 2018
@tombuildsstuff tombuildsstuff deleted the fix-elasticpool-crash branch March 15, 2018 12:40
tombuildsstuff added a commit that referenced this pull request Mar 15, 2018
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
crash service/mssql Microsoft SQL Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform crashed while importing Elastic pool module
2 participants