-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_media_services_account - support for 'identity', 'tags' and 'storage_authentication' #9457
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jcanizalez - given this a review and left some comments inline 🙂
azurerm/internal/services/media/media_services_account_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/media/media_services_account_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/media/media_services_account_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/media/media_services_account_resource.go
Outdated
Show resolved
Hide resolved
Thanks @katbyte I already applied your suggestions |
Hi @jcanizalez - Hope you don't mind, but I fixed a potential panic for the new property and I switched over to the new IDs while I was there. I'll get the tests run shortly and assuming they pass OK, we'll get this merged later today. Thanks again for the contribution! |
Thanks @jackofallops |
This has been released in version 2.39.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.39.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Including the support for the properties Identity and Storage Authentication in Azure Media Services Account. In order to support new fields was required to update the API version to new version 2020-05-01, but I have already validated that the Acceptance test still works. Additional take advantage of including support for tags. This PR resolves #9404
Checked: