-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add field for virtual network gateway and virtual network gateway connection #9330
Conversation
Co-authored-by: Arcturus <[email protected]>
Co-authored-by: Arcturus <[email protected]>
Co-authored-by: Arcturus <[email protected]>
Co-authored-by: Arcturus <[email protected]>
Co-authored-by: Arcturus <[email protected]>
…urce.go Co-authored-by: Arcturus <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've left some comments inline to address
azurerm/internal/services/network/virtual_network_gateway_connection_data_source.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/network/virtual_network_gateway_connection_resource.go
Outdated
Show resolved
Hide resolved
…ection_data_source.go Co-authored-by: kt <[email protected]>
…ection_resource.go Co-authored-by: kt <[email protected]>
Co-authored-by: kt <[email protected]>
@katbyte Thanks for your review! I changed the code according to your comments. pls help to review this pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM now 👍
@katbyte Could you pls help to merge this pr, I have no permission to merge, thx. |
Was waiting for tests to pass, they have now so merging! |
This has been released in version 2.38.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.38.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
No description provided.