-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fields for App Service and App Service Slot #9162
Add fields for App Service and App Service Slot #9162
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @daxsorbito
Thanks for this PR, it's off to a good start. I've left some comments and changes/suggestions below.
azurerm/internal/services/web/tests/resource_arm_app_service_slot_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/web/tests/resource_arm_app_service_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/web/tests/resource_arm_app_service_slot_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/web/tests/resource_arm_app_service_slot_test.go
Outdated
Show resolved
Hide resolved
…ed log properties on App Service and App Service slot
f2ce6f2
to
ca7f945
Compare
Hi @daxsorbito - I hope you don't mind, but I've fixed up the merge conflicts here and updated the tests to the match the rest in the package. I'll get the tests run for this today and it should be good for today's release if everything looks good. Thanks again for your contribution 👍 |
This has been released in version 2.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.42.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Background
This PR adds
detailed_error_mesage_enabled
andfailed_request_tracing_enabled
properties to theApp Service
andApp Service Slot
resources'slog
argument reference.Both fields are
optional
and have a default value offalse
.This is a fix for this issue: #7050
Usage
azurerm_app_service
azurerm_app_service_slot
Test Result