azurerm_function_app - make pre_warmed_instance_count computed to use azure's default

[RiverPhillips]

This resolves #9066 by setting the default prewarmed pre_warmed_instance_count to 1

[jackofallops]

Hi @RiverPhillips - Thanks for this PR. I think this was left without a default due to non-premium SKU's discarding this value, so would create a Diff as the value will be 0 when read back from the API. As such, this would probably need to be validated / adjusted in code, or possibly just updated in the documentation for appropriate usage guidance? WDYT?

[RiverPhillips]

HI @jackofallops thanks for your feedback. I think it would be sensible if we defaulted to 1 for all plans except for the consumption plan. I think that should solve the issue you raised surrounding the diff. Or we could require it be set for non-consumption SKUs.

[katbyte]

@RiverPhillips - instead of adding a default here maybe we could change it to computed to let azure pick the default?

[RiverPhillips]

@katbyte - I hadn't considered that approach, I think it's the most practical and future proof so I have made that change

[katbyte]

Thanks @RiverPhillips - this LGTM 👍

[ghost]

This has been released in version 2.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.42.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!