azurerm_kubernetes_cluster - Fix issue where min_count and max_count couldn't be the same
#8957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get latest source
…_count both for default as well as other node pools
…_count both for default as well as other node pools
added 2 commits
October 20, 2020 23:02
…_count both for default as well as other node pools
…_count both for default as well as other node pools
mbfrahry
changed the title
azurerm_kubernetes_cluster - Fix issue where min_count and max_count couldn't be the same
mbfrahry
added a commit
that referenced
this pull request
Oct 22, 2020
|
This has been released in version 2.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.34.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #8944. The min_count of nodes can be same as max_count both for default as well as other node pools
Written couple of additional tests - one each for cluster default node pool and explicit node pools.
The tests have passed.
riteshmodi@MININT-3FOKASG terraform-provider-azurerm % TF_PROVIDER_SPLIT_COMBINED_TESTS=1 TF_ACC=1 go test -v ./azurerm/internal/services/containers/tests/ -timeout=60m -run=TestAccAzureRMKubernetesCluster_sameSize
=== RUN TestAccAzureRMKubernetesCluster_sameSize
=== PAUSE TestAccAzureRMKubernetesCluster_sameSize
=== CONT TestAccAzureRMKubernetesCluster_sameSize
--- PASS: TestAccAzureRMKubernetesCluster_sameSize (1017.63s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/containers/tests 1017.697s
riteshmodi@MININT-3FOKASG terraform-provider-azurerm % TF_PROVIDER_SPLIT_COMBINED_TESTS=1 TF_ACC=1 go test -v ./azurerm/internal/services/containers/tests/ -timeout=60m -run=TestAccAzureRMKubernetesClusterNodePool_sameSize
=== RUN TestAccAzureRMKubernetesClusterNodePool_sameSize
=== PAUSE TestAccAzureRMKubernetesClusterNodePool_sameSize
=== CONT TestAccAzureRMKubernetesClusterNodePool_sameSize
--- PASS: TestAccAzureRMKubernetesClusterNodePool_sameSize (1032.67s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/containers/tests 1032.733s