Added Redis Cache firewall resource start and end IP address validations #8948
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Redis Cache firewall resource start and end IP address validations such that the request fails at plan level rather than apply. The validations will provide feedback for invalid ip addresses during plan itself.
Details of acceptance tests
riteshmodi@MININT-3FOKASG terraform-provider-azurerm % make acctests SERVICE=redis TESTARGS='-run=TestAccAzureRMRedisFirewallRule' TESTTIMEOUT='120m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/redis/tests/ -run=TestAccAzureRMRedisFirewallRule -timeout 120m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccAzureRMRedisFirewallRule_basic
=== PAUSE TestAccAzureRMRedisFirewallRule_basic
=== RUN TestAccAzureRMRedisFirewallRule_multi
=== PAUSE TestAccAzureRMRedisFirewallRule_multi
=== RUN TestAccAzureRMRedisFirewallRule_requiresImport
=== PAUSE TestAccAzureRMRedisFirewallRule_requiresImport
=== RUN TestAccAzureRMRedisFirewallRule_update
=== PAUSE TestAccAzureRMRedisFirewallRule_update
=== CONT TestAccAzureRMRedisFirewallRule_basic
=== CONT TestAccAzureRMRedisFirewallRule_update
=== CONT TestAccAzureRMRedisFirewallRule_requiresImport
=== CONT TestAccAzureRMRedisFirewallRule_multi
--- PASS: TestAccAzureRMRedisFirewallRule_requiresImport (1324.42s)
--- PASS: TestAccAzureRMRedisFirewallRule_update (1395.16s)
--- PASS: TestAccAzureRMRedisFirewallRule_multi (1432.15s)
--- PASS: TestAccAzureRMRedisFirewallRule_basic (1491.06s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/redis/tests 1491.109s