Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_servicebus_subscription_rule - support correlation_filter.properties #8646

Merged
merged 8 commits into from
Sep 29, 2020
Merged

Conversation

jarrodd07
Copy link
Contributor

Fix #8350

@jarrodd07 jarrodd07 marked this pull request as draft September 27, 2020 06:59
@jarrodd07 jarrodd07 marked this pull request as ready for review September 27, 2020 07:50
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jarrodd07 - aside from one minor comment this LGTM 👍

@ghost ghost added size/XS and removed size/S labels Sep 29, 2020
@katbyte katbyte changed the title Adding user defined properties to service bus correlation filters azurerm_servicebus_subscription_rule - support correlation_filter.properties Sep 29, 2020
@katbyte katbyte added this to the v2.30.0 milestone Sep 29, 2020
@katbyte katbyte merged commit e50d48b into hashicorp:master Sep 29, 2020
katbyte added a commit that referenced this pull request Sep 29, 2020
@ghost
Copy link

ghost commented Oct 1, 2020

This has been released in version 2.30.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.30.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for user-defined properties in Service Bus subscription correlation filters
2 participants