azurerm_cosmosdb_sql_container - support for indexing_policy

[marc-sensenich]

Allows for the setting of indexing policies on Cosmos DB SQL Containers. Completes the work from #5546.

Test status as of e06ca00

--- PASS: TestAccAzureRMCosmosDbSqlContainer_basic (1600.44s)
--- PASS: TestAccAzureRMCosmosDbSqlContainer_complete (1713.66s)
--- PASS: TestAccAzureRMCosmosDbSqlContainer_update (1775.82s)
--- PASS: TestAccAzureRMCosmosDbSqlContainer_indexing_policy (1821.13s)
--- PASS: TestAccAzureRMCosmosDbSqlContainer_autoscale (1940.55s)

[marc-sensenich]

Added these to common as the Gremlin Graph resource could migrate over to these in the future

[marc-sensenich]

I only did path here as the indexes field was accepted by the REST API, but did not return the indexes field in response.

[marc-sensenich]

Is there a suggested pattern for validating TypeList that does cross field validation? In the indexing policy case there are the validations of

• included_path and excluded_path can't be set when the indexing_mode is None
• One of included_path or excluded_path must contain the path /*

[katbyte]

The best solution is to validate it in create and return an error at that point if it fails

[katbyte]

Thanks for the PR @marc-sensenich - overall looks good to me! if we can add that validation to the create/update function this should be good to merge 🙁

[katbyte]

The best solution is to validate it in create and return an error at that point if it fails

[marc-sensenich]

@katbyte validation on create and update added in e06ca00

[katbyte]

thanks @marc-sensenich - running the tests for the latest changes however and i'm getting:

Test Failed

------- Stdout: -------
=== RUN   TestValidateAzureRmCosmosDbIndexingPolicy
    TestValidateAzureRmCosmosDbIndexingPolicy: indexing_policy_test.go:198: Expected an error but didn't get one for "included_path and excluded_path with /*"
--- FAIL: TestValidateAzureRmCosmosDbIndexingPolicy (0.00s)

[katbyte]

NM @marc-sensenich, ran it again and it passed! thanks for the changes 🙂

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!