Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data.function_app - export the identity block #8389

Merged
merged 3 commits into from
Sep 11, 2020
Merged

data.function_app - export the identity block #8389

merged 3 commits into from
Sep 11, 2020

Conversation

favoretti
Copy link
Collaborator

@favoretti favoretti commented Sep 8, 2020

Fixes #8285

@ghost ghost added the size/S label Sep 8, 2020
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@favoretti thanks for adding this. These changes look good but we should add a test to make sure it works correctly and add it to the docs.

@ghost ghost added documentation size/M and removed size/S labels Sep 10, 2020
@favoretti
Copy link
Collaborator Author

@mbfrahry Thank you for your review. I added identity checks to the _basic test, rather than created a new one - I hope that's ok?

@favoretti favoretti requested a review from mbfrahry September 10, 2020 11:29
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @favoretti! LGTM 👍

@katbyte katbyte added the service/functions Function Apps label Sep 11, 2020
@katbyte katbyte added this to the v2.28.0 milestone Sep 11, 2020
@katbyte katbyte changed the title Add identity to function_app datasource data.function_app - export the identity block Sep 11, 2020
@katbyte katbyte merged commit 44d7004 into hashicorp:master Sep 11, 2020
katbyte added a commit that referenced this pull request Sep 11, 2020
@ghost
Copy link

ghost commented Sep 17, 2020

This has been released in version 2.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.28.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for identity in azurerm_function_app datasource.
3 participants