-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update azurerm_cosmosdb_account
- support zone redundancy
#8295
Update azurerm_cosmosdb_account
- support zone redundancy
#8295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @ArcturusZhang
Thanks for this PR :)
Taking a look through this is off to a good start - if we can fix up the comments then we should be able to run the tests and get this merged 👍
Thanks!
|
||
buf.WriteString(fmt.Sprintf("%s-%d", location, priority)) | ||
buf.WriteString(fmt.Sprintf("%s-%d-%v", location, priority, isZoneRedundant)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need a state migration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decide to revert this change, since we could not have two items with the same location and priority, but one of them has true
for zone_redundant
and another is false
. Therefore I think there is no point to modify this hash function.
azurerm/internal/services/cosmos/tests/cosmosdb_account_resource_test.go
Outdated
Show resolved
Hide resolved
0c45fb3
to
7933041
Compare
Hi @tombuildsstuff I have made some changes, please have a look. Thanks! The new test cases are passing:
|
This has been released in version 2.30.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.30.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Fixes #8010