Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azurerm_cosmosdb_account - support zone redundancy #8295

Merged
merged 13 commits into from
Sep 25, 2020

Conversation

ArcturusZhang
Copy link
Contributor

@ArcturusZhang ArcturusZhang commented Aug 31, 2020

Fixes #8010

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @ArcturusZhang

Thanks for this PR :)

Taking a look through this is off to a good start - if we can fix up the comments then we should be able to run the tests and get this merged 👍

Thanks!


buf.WriteString(fmt.Sprintf("%s-%d", location, priority))
buf.WriteString(fmt.Sprintf("%s-%d-%v", location, priority, isZoneRedundant))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need a state migration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decide to revert this change, since we could not have two items with the same location and priority, but one of them has true for zone_redundant and another is false. Therefore I think there is no point to modify this hash function.

@ArcturusZhang ArcturusZhang force-pushed the cosmosdb-redundant-zone branch from 0c45fb3 to 7933041 Compare September 2, 2020 03:32
@ghost ghost added size/M and removed size/S labels Sep 7, 2020
@ArcturusZhang
Copy link
Contributor Author

Hi @tombuildsstuff I have made some changes, please have a look. Thanks!

The new test cases are passing:

=== RUN   TestAccAzureRMCosmosDBAccount_completeZoneRedundant_mongo
=== PAUSE TestAccAzureRMCosmosDBAccount_completeZoneRedundant_mongo
=== CONT  TestAccAzureRMCosmosDBAccount_completeZoneRedundant_mongo
--- PASS: TestAccAzureRMCosmosDBAccount_completeZoneRedundant_mongo (2574.71s)
=== RUN   TestAccAzureRMCosmosDBAccount_completeZoneRedundant_global
=== PAUSE TestAccAzureRMCosmosDBAccount_completeZoneRedundant_global
=== CONT  TestAccAzureRMCosmosDBAccount_completeZoneRedundant_global
--- PASS: TestAccAzureRMCosmosDBAccount_completeZoneRedundant_global (2157.68s)
=== RUN   TestAccAzureRMCosmosDBAccount_completeZoneRedundant_parse
=== PAUSE TestAccAzureRMCosmosDBAccount_completeZoneRedundant_parse
=== CONT  TestAccAzureRMCosmosDBAccount_completeZoneRedundant_parse
--- PASS: TestAccAzureRMCosmosDBAccount_completeZoneRedundant_parse (2284.56s)
PASS

@katbyte katbyte added this to the v2.30.0 milestone Sep 25, 2020
@katbyte katbyte merged commit 70e9dfe into hashicorp:master Sep 25, 2020
katbyte added a commit that referenced this pull request Sep 25, 2020
@ArcturusZhang ArcturusZhang deleted the cosmosdb-redundant-zone branch September 26, 2020 04:13
@ghost
Copy link

ghost commented Oct 1, 2020

This has been released in version 2.30.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.30.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support in Cosmos DB for Availability Zone is supported regions
3 participants