Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/network_interface_*association: handling the Network Interface being deleted during a refresh #8267

Merged
merged 6 commits into from
Aug 28, 2020

Conversation

tombuildsstuff
Copy link
Contributor

changes:

  • azurerm_network_interface_application_gateway_association - handling the Network Interface being deleted during a refresh
  • azurerm_network_interface_application_security_group_association - handling the Network Interface being deleted during a refresh
  • azurerm_network_interface_backend_address_pool_association - handling the Network Interface being deleted during a refresh
  • azurerm_network_interface_nat_rule_association_resource - handling the Network Interface being deleted during a refresh
  • azurerm_network_interface_network_security_group_association - handling the Network Interface being deleted during a refresh

fixes #2491

@ghost ghost added the size/XS label Aug 27, 2020
@tombuildsstuff tombuildsstuff requested a review from a team August 27, 2020 06:39
@tombuildsstuff tombuildsstuff added this to the v2.25.0 milestone Aug 27, 2020
@tombuildsstuff tombuildsstuff modified the milestones: v2.25.0, v2.26.0 Aug 27, 2020
@tombuildsstuff
Copy link
Contributor Author

Tests pass:

Screenshot 2020-08-27 at 10 28 43

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff tombuildsstuff merged commit 9e57d7d into master Aug 28, 2020
@tombuildsstuff tombuildsstuff deleted the b/association-read-when-gone branch August 28, 2020 05:24
tombuildsstuff added a commit that referenced this pull request Aug 28, 2020
@ghost
Copy link

ghost commented Sep 4, 2020

This has been released in version 2.26.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.26.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants