-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add azurerm_firewall management IP configuration #8235
Add azurerm_firewall management IP configuration #8235
Conversation
…vider-azurerm into add-azure-firewall-management-ip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @caius
Thanks for this PR :)
Taking a look through this is off to a good start - if we can fix up the comments left inline (and the tests pass) then this otherwise LGTM 👍
Thanks!
Co-authored-by: Tom Harvey <[email protected]>
Co-authored-by: Tom Harvey <[email protected]>
* `ip_configuration` - (Required) A `ip_configuration` block as documented below. | ||
* `ip_configuration` - (Required) An `ip_configuration` block as documented below. | ||
|
||
* `management_ip_configuration` - (Optional) A `management_ip_configuration` block as documented below, which allows force-tunnelling of traffic to be performed by the firewall. Changing this forces a new resource to be created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not sure about the wording. You can change the management_ip_configuration
block without recreating the firewall. It only forces a new resource when you change the subnet_id
. Adding or removing the block does force a new resource of course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dragetta I think you pretty much got it there! How about:
* `management_ip_configuration` - (Optional) A `management_ip_configuration` block as documented below, which allows force-tunnelling of traffic to be performed by the firewall. Changing this forces a new resource to be created. | |
* `management_ip_configuration` - (Optional) A `management_ip_configuration` block as documented below, which allows force-tunnelling of traffic to be performed by the firewall. You can add and remove this block, however changing `subnet_id` in an existing block forces a new resource to be created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manicminer I've adjusted your wording a bit. Let me know if this is ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@draggeta briiliant 👍
Co-authored-by: Tom Bamford <[email protected]>
Update description of the management_ip_config
This has been released in version 2.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.28.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
This PR adds the management IP configuration for the Azure Firewall. This allows for forced tunneling to be configured by configuring a UDR on the AzureFirewallSubnet.
To do:
Closes #7152
Acceptance test