Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_*.*.zone - can no longer be passed in as empty #8233

Merged
merged 3 commits into from
Aug 25, 2020
Merged

Conversation

mbfrahry
Copy link
Member

Fixes #8232

@ghost ghost added the size/XS label Aug 24, 2020
@mbfrahry mbfrahry requested a review from a team August 24, 2020 20:31
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from one comment 🚀

azurerm/helpers/azure/zones.go Outdated Show resolved Hide resolved
@mbfrahry mbfrahry merged commit 5fe2ea0 into master Aug 25, 2020
@mbfrahry mbfrahry deleted the c-empty-zones branch August 25, 2020 17:37
mbfrahry added a commit that referenced this pull request Aug 25, 2020
tombuildsstuff added a commit that referenced this pull request Aug 26, 2020
@ghost
Copy link

ghost commented Sep 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform crashes when you pass null value to availability zone - azure
2 participants