Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleaning up load balancers & adding validation to Load Balancer ID's & at import time #8172

Merged
merged 15 commits into from
Aug 20, 2020

Conversation

tombuildsstuff
Copy link
Contributor

This PR refactors the Load Balancer resources to use common ID parsers - as a first step to refactoring these resources

It also adds both import-time and field validation for the Load Balancer ID's, rather than just taking a generic Resource ID - so we can ensure these are consistent. It's worth noting this is intentionally a first-step - there's more to do here, but this is a good cut point for now

Tests pass:

Screenshot 2020-08-19 at 16 33 05

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tombuildsstuff - other than a few missed error message tweaks LGTM 👍

azurerm/internal/services/network/lb_rule_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/network/lb_rule_resource.go Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff merged commit bd9b4cd into master Aug 20, 2020
@tombuildsstuff tombuildsstuff deleted the refactor/load-balancers branch August 20, 2020 13:43
tombuildsstuff added a commit that referenced this pull request Aug 20, 2020
@ghost
Copy link

ghost commented Aug 20, 2020

This has been released in version 2.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.24.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants