-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource/data source azurerm_storage_sync
#7843
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yupwei68 - LGTM aside from 2 comments
azurerm/internal/services/storage/tests/resource_arm_storage_sync_test.go
Outdated
Show resolved
Hide resolved
func testAccAzureRMStorageSync_complete(data acceptance.TestData) string { | ||
return fmt.Sprintf(` | ||
resource "azurerm_resource_group" "test" { | ||
name = "acctestRG-%d" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name = "acctestRG-%d" | |
name = "acctestRG-ss-%d" |
This has been released in version 2.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.28.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Partial fix: #2315.
Totally there will be three resources:
azurerm_storage_sync
azurerm_storage_sync_group
azurerm_cloud_endpoint
=== RUN TestAccAzureRMStorageSync_basic
=== PAUSE TestAccAzureRMStorageSync_basic
=== CONT TestAccAzureRMStorageSync_basic
--- PASS: TestAccAzureRMStorageSync_basic (251.79s)
=== RUN TestAccAzureRMStorageSync_requiresImport
=== PAUSE TestAccAzureRMStorageSync_requiresImport
=== CONT TestAccAzureRMStorageSync_requiresImport
--- PASS: TestAccAzureRMStorageSync_requiresImport (252.79s)
=== RUN TestAccAzureRMStorageSync_complete
=== PAUSE TestAccAzureRMStorageSync_complete
=== CONT TestAccAzureRMStorageSync_complete
--- PASS: TestAccAzureRMStorageSync_complete (265.19s)
=== RUN TestAccAzureRMStorageSync_update
=== PAUSE TestAccAzureRMStorageSync_update
=== CONT TestAccAzureRMStorageSync_update
--- PASS: TestAccAzureRMStorageSync_update (453.82s)
=== RUN TestAccDataSourceAzureRMStorageSync_basic
=== PAUSE TestAccDataSourceAzureRMStorageSync_basic
=== CONT TestAccDataSourceAzureRMStorageSync_basic
--- PASS: TestAccDataSourceAzureRMStorageSync_basic (246.94s)