add soft_delete_retention_days support for azurerm_key_vault

[njuCZ]

fix #6665
fix #7178

this is a new field in api-version: 2019-09-01
once soft_delete_retention_days is set, it could not be updated

if soft_delete_enabled is true, and not set soft_delete_retention_days, the resp softDeleteRetentionInDays is also nil, so no influence to existing test case.

[tombuildsstuff]

hey @njuCZ

Thanks for this PR - apologies for the delayed review here!

I've taken a look through and left some comments inline but this is looking good - if we can fix those up then we should be able to take another look and get this merged 👍🏻

Thanks!

[njuCZ]

@tombuildsstuff I have modified this PR, could you please have a look again?

[tombuildsstuff]

LGTM 👍

[tombuildsstuff]

Tests pass:

[ghost]

This has been released in version 2.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.25.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!