Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azurerm_orchestrated_virtual_machine_scale_set - Remove the validation for single_placement_group #7821

Merged
merged 5 commits into from
Aug 11, 2020

Conversation

ArcturusZhang
Copy link
Contributor

No description provided.

@ghost ghost added the size/XS label Jul 21, 2020
@katbyte katbyte self-assigned this Jul 22, 2020
Optional: true,
ForceNew: true,
Default: false,
Deprecated: "Due to an upgrade of the compute API this preview property has now been deprecated and required to be false in the 2019-12-01 api versions for orchestrated VMSS - as it will always be false for the current and future API versions this property now defaults to false and will removed in version 3.0 of the provider.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THis deprecation message should be removed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and docs maybe updated?

Optional: true,
ForceNew: true,
Default: false,
Deprecated: "Due to an upgrade of the compute API this preview property has now been deprecated and required to be false in the 2019-12-01 api versions for orchestrated VMSS - as it will always be false for the current and future API versions this property now defaults to false and will removed in version 3.0 of the provider.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and docs maybe updated?

@katbyte katbyte added bug service/vmss Virtual Machine Scale Sets labels Jul 23, 2020
@ghost ghost added documentation size/S and removed size/XS labels Jul 24, 2020
@ArcturusZhang
Copy link
Contributor Author

Hi @katbyte I have removed the deprecation message and also changed the doc. Please have a look, thanks

@ArcturusZhang ArcturusZhang requested a review from katbyte July 24, 2020 08:39
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte added this to the v2.23.0 milestone Aug 11, 2020
@katbyte katbyte merged commit 1add778 into hashicorp:master Aug 11, 2020
katbyte added a commit that referenced this pull request Aug 11, 2020
@ArcturusZhang ArcturusZhang deleted the fix-vmss-orchestration-mode branch August 11, 2020 00:12
@ghost
Copy link

ghost commented Aug 13, 2020

This has been released in version 2.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.23.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants