azurerm_express_route_circuit: fix acctest (actually a bug)

[magodo]

Express Route Circuit appears to be eventually consisitent on creation (maybe only when recreated), which is tracked in issue: Azure/azure-rest-api-specs#10148.

Test Result

💢 make testacc TEST=./azurerm/internal/services/network/tests TESTARGS='-run TestAccAzureRMExpressRouteCircuit_bandwidthReduction'

==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/network/tests -v -run TestAccAzureRMExpressRouteCircuit_bandwidthReduction -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccAzureRMExpressRouteCircuit_bandwidthReduction
--- PASS: TestAccAzureRMExpressRouteCircuit_bandwidthReduction (332.62s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/network/tests 332.661s

[jackofallops]

Hi @magodo

Thanks for this update to work around the issue you've raised on the api-specs. The change LGTM, so if you can goimports the resource file to allow travis to pass the build I think we should be good to merge.

[magodo]

@jackofallops Thank you for granting my PR, I have passed CI now.

[jackofallops]

Thanks @magodo - Looking good now. I was about to run the tests for this but have found that there's a nil panic that will prevent this part of the acctest suite running completely. I'm going to fix that up first, then we'll (hopefully) be able to test this properly.

[jackofallops]

Update: panic fix merged, this is now running through testing.

[jackofallops]

Tests passing:

[ghost]

This has been released in version 2.19.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.19.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!