Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Property for hbi_enabled with machine learning workspace #7703

Merged
merged 4 commits into from
Jul 14, 2020
Merged

Property for hbi_enabled with machine learning workspace #7703

merged 4 commits into from
Jul 14, 2020

Conversation

damienpontifex
Copy link
Contributor

@damienpontifex damienpontifex commented Jul 12, 2020 •
edited
Loading

  • Updates ML workspace API version from 2019-11-01 -> 2020-04-01
  • Adds high_business_impact_workspace property to workspace to indicate high business impact resulting in reduced sensitive data and telemetry collected by Microsoft

@damienpontifex
Property for hbi_enabled with ML Workspace
a15ab4e 
- Updates ML workspace API version from 2019-11-01 -> 2020-04-01
- Adds hbi_enabled property to workspace to indicate high business
impact resulting in reduced sensitive data and telemetry collected by
Microsoft
@damienpontifex damienpontifex marked this pull request as draft July 13, 2020 09:14
@damienpontifex damienpontifex marked this pull request as ready for review July 13, 2020 10:14
tombuildsstuff
tombuildsstuff suggested changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @damienpontifex

Thanks for this PR :)

Taking a look through this mostly LGTM - however it sounds like it could be worth making this field high_business_impact_workspace so this is clearer - could we update this?

Thanks!

website/docs/r/machine_learning_workspace.html.markdown Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff added this to the v2.19.0 milestone Jul 13, 2020
tombuildsstuff
tombuildsstuff approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for pushing those changes @damienpontifex

@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2020-07-14 at 11 11 17

@tombuildsstuff tombuildsstuff merged commit 4e32708 into hashicorp:master Jul 14, 2020
tombuildsstuff added a commit that referenced this pull request Jul 14, 2020
@tombuildsstuff
updating to include #7703
473ae12
@damienpontifex damienpontifex deleted the ml_workspace_hbi_enabled branch July 14, 2020 09:12
@ghost
Copy link

ghost commented Jul 16, 2020

This has been released in version 2.19.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.19.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
dependencies documentation enhancement service/machine-learning size/XXL
Projects
None yet
Milestone
v2.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@damienpontifex @tombuildsstuff