Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eventhub_namespace: force new resource on zone_redundant change #7612

Merged
merged 6 commits into from
Jul 10, 2020
Merged

eventhub_namespace: force new resource on zone_redundant change #7612

merged 6 commits into from
Jul 10, 2020

Conversation

favoretti
Copy link
Collaborator

@favoretti favoretti commented Jul 7, 2020 •
edited
Loading

Fixes #7606

@ghost ghost added the size/XS label Jul 7, 2020
@favoretti favoretti changed the title Eventhub: force new resource on zone_redundant change eventhub_namespace: force new resource on zone_redundant change Jul 7, 2020
@ghost ghost added the documentation label Jul 7, 2020
@favoretti
Copy link
Collaborator Author

favoretti commented Jul 8, 2020 •
edited
Loading

@tombuildsstuff Minor one here. Can you please have a look?

@tombuildsstuff tombuildsstuff added this to the v2.19.0 milestone Jul 10, 2020
tombuildsstuff
tombuildsstuff approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2020-07-10 at 12 01 40

@tombuildsstuff tombuildsstuff merged commit ad05c7a into hashicorp:master Jul 10, 2020
tombuildsstuff added a commit that referenced this pull request Jul 10, 2020
@tombuildsstuff
updating to include #7612
39e7f94
@ghost
Copy link

ghost commented Jul 16, 2020

This has been released in version 2.19.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.19.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 9, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
documentation enhancement service/event-hubs EventHubs size/XS
Projects
None yet
Milestone
v2.19.0
Development

Successfully merging this pull request may close these issues.

Updating the ZoneRedundant property on a namespace is not supported
2 participants
@favoretti @tombuildsstuff