Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect validatefunc on azurerm_policy_remediation #7600

Merged
merged 3 commits into from
Jul 7, 2020

Conversation

matt-FFFFFF
Copy link
Contributor

fixes #7599 by removing incorrect validatefunc

As confirmed in the official docs the PolicyDefinitionReferenceId is simply A unique id (within the policy set definition) for this policy definition reference. and is not a resource id to a policydefinition.

@ghost ghost added the size/XS label Jul 6, 2020
@matt-FFFFFF matt-FFFFFF changed the title Remove incorrect validatefunc Remove incorrect validatefunc on azurerm_policy_remediation Jul 6, 2020
@ghost ghost added the documentation label Jul 6, 2020
Copy link
Contributor

@ArcturusZhang ArcturusZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @matt-FFFFFF
thanks for this PR!
This PR looks great, while I suppose in the documentation we could remove the misleading first part and replace it with the note you added in this PR. What do you think?

website/docs/r/policy_remediation.html.markdown Outdated Show resolved Hide resolved
Co-authored-by: Arcturus <[email protected]>
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @matt-FFFFFF 👍

@tombuildsstuff tombuildsstuff added this to the v2.18.0 milestone Jul 7, 2020
@tombuildsstuff tombuildsstuff merged commit 48a6358 into hashicorp:master Jul 7, 2020
tombuildsstuff added a commit that referenced this pull request Jul 7, 2020
@matt-FFFFFF matt-FFFFFF deleted the matt-FFFFFF-patch-1 branch July 7, 2020 19:36
@ghost
Copy link

ghost commented Jul 10, 2020

This has been released in version 2.18.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.18.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Policy remediation has incorrect ValidateFunc on policy_definition_reference_id
3 participants