Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_web_application_firewall_policy: custom_rules.match_conditions support transforms #7545

Merged

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Jul 1, 2020

Support transforms for custom rule condition in waf policy. Additionally, modify the document a bit to mark manged_rules as required, as defined in schema.

Test Result

terraform-provider-azurerm on  waf_policy_custom_rule_support_transform [$!] took 3m 16s 
💤 😡 130 via 🦉 v1.14.4 make testacc TEST=./azurerm/internal/services/network/tests TESTARGS='-run TestAccAzureRMWebApplicationFirewallPolicy_update'
                                                                                                                                                                                     
==> Checking that code complies with gofmt requirements...                      
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...           
TF_ACC=1 go test ./azurerm/internal/services/network/tests -v -run TestAccAzureRMWebApplicationFirewallPolicy_update -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMWebApplicationFirewallPolicy_update                   
=== PAUSE TestAccAzureRMWebApplicationFirewallPolicy_update
=== CONT  TestAccAzureRMWebApplicationFirewallPolicy_update
--- PASS: TestAccAzureRMWebApplicationFirewallPolicy_update (211.65s)         
PASS                                                                                                                                                                                                                                                                                                                                                                       
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/network/tests       211.667s   

(fix #5359 )

Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @magodo, this looks great 👍

@manicminer manicminer merged commit 1c236c7 into hashicorp:master Jul 7, 2020
manicminer added a commit that referenced this pull request Jul 7, 2020
@ghost
Copy link

ghost commented Jul 10, 2020

This has been released in version 2.18.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.18.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for transforms in custom Azure web application firewall rules
2 participants