-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource azurerm_data_share_dataset_data_lake_gen1
#7511
New resource azurerm_data_share_dataset_data_lake_gen1
#7511
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yupwei68, thanks for opening this PR... it looks more or less really good, however I did leave a few comments on some very minor changes I would like to see done. Thanks again! 🚀
azurerm/internal/services/datashare/resource_arm_data_share_dataset_data_lake_gen1.go
Show resolved
Hide resolved
azurerm/internal/services/datashare/resource_arm_data_share_dataset_data_lake_gen1.go
Outdated
Show resolved
Hide resolved
Hi @WodansSon Thanks for your comments. Corresponding changes have been pushed. Please continue reviewing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yupwei68, awesome! thanks for pushing those changes. This LGTM now! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pr @yupwei68 - aside from my one comment about a schema change this LGTM 👍
azurerm/internal/services/datashare/resource_arm_data_share_dataset_data_lake_gen1.go
Outdated
Show resolved
Hide resolved
hi @katbyte Thanks for your comments. Corresponding changes have been pushed. Please continue reviewing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yupwei68! LGTM 👍
This has been released in version 2.20.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.20.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Partially fix #6480
Sub PR of : #7064
=== RUN TestAccAzureRMDataShareDataSetDataLakeGen1File_basic
=== PAUSE TestAccAzureRMDataShareDataSetDataLakeGen1File_basic
=== CONT TestAccAzureRMDataShareDataSetDataLakeGen1File_basic
--- PASS: TestAccAzureRMDataShareDataSetDataLakeGen1File_basic (395.53s)
=== RUN TestAccAzureRMDataShareDataSetDataLakeGen1Folder_basic
=== PAUSE TestAccAzureRMDataShareDataSetDataLakeGen1Folder_basic
=== CONT TestAccAzureRMDataShareDataSetDataLakeGen1Folder_basic
--- PASS: TestAccAzureRMDataShareDataSetDataLakeGen1Folder_basic (335.91s)
=== RUN TestAccAzureRMDataShareDataSetDataLakeGen1_requiresImport
=== PAUSE TestAccAzureRMDataShareDataSetDataLakeGen1_requiresImport
=== CONT TestAccAzureRMDataShareDataSetDataLakeGen1_requiresImport
--- PASS: TestAccAzureRMDataShareDataSetDataLakeGen1_requiresImport (410.60s)