Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update azurerm_orchestrated_virtual_machine_scale_set - Add proximity placement group support #7510

Merged
merged 12 commits into from
Jul 14, 2020
Merged

Update azurerm_orchestrated_virtual_machine_scale_set - Add proximity placement group support #7510

merged 12 commits into from
Jul 14, 2020

Conversation

ArcturusZhang
Copy link
Contributor

No description provided.

@ArcturusZhang ArcturusZhang added the service/vmss Virtual Machine Scale Sets label Jun 28, 2020
tombuildsstuff
tombuildsstuff suggested changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @ArcturusZhang

Thanks for this PR :)

Taking a look through this mostly LGTM - we just need to ensure there's a link to the issue tracking this RFC 2616 issue in the Azure API - if we can add this (and the tests pass) then this should otherwise be good to merge.

Thanks!

azurerm/internal/services/compute/orchestrated_virtual_machine_scale_set_resource.go
ForceNew: true,
ValidateFunc: validate.ProximityPlacementGroupID,
// the Compute/VM API is broken and returns the Resource Group name in UPPERCASE :shrug:
DiffSuppressFunc: suppress.CaseDifference,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there an API bug tracking this so that the Compute API complies with RFC 2616?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I noticed this issue and checked the VMSS resources (they have a proximity_placement_group_id atttribute too) and found this comment. As a result I just copied the comment here.
Specs repo does not have an issue tracking this now. I will open a new one and update the comment here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue created: Azure/azure-rest-api-specs#10016

@ArcturusZhang
Copy link
Contributor Author

Hi @tombuildsstuff I opened an issue to track this issue, and added the link to the comment. Please have a look, thanks

@tombuildsstuff tombuildsstuff self-assigned this Jul 2, 2020
@katbyte katbyte added this to the v2.19.0 milestone Jul 14, 2020
katbyte
katbyte approved these changes Jul 14, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArcturusZhang - LGTM

@katbyte katbyte merged commit b46afd2 into hashicorp:master Jul 14, 2020
katbyte added a commit that referenced this pull request Jul 14, 2020
@katbyte
update CHANGELOG.md to include #7510
9bf2660
@ArcturusZhang ArcturusZhang deleted the add-proximity-placement-group-support-for-orchestrated-VMSS branch July 15, 2020 05:51
@ghost
Copy link

ghost commented Jul 16, 2020

This has been released in version 2.19.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.19.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff requested changes

@katbyte katbyte katbyte approved these changes

Assignees

@tombuildsstuff tombuildsstuff

Labels
documentation service/vmss Virtual Machine Scale Sets size/L
Projects
None yet
Milestone
v2.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ArcturusZhang @tombuildsstuff @katbyte