azurerm_kusto_cluster - support for language_extensions #7421
Conversation
|
Currently there is a problem within the REST API (see Azure/azure-rest-api-specs#9910). Maybe a workaround would be to use the |
jrauschenbusch
force-pushed
the
r-kusto-cluster-language-extensions
branch
from
2c93993 to
c9d5392
Compare
There was a problem hiding this comment.
hey @jrauschenbusch
Thanks for this PR :)
Taking a look through this mostly LGTM - it sounds like we should be able to fix the tests for this by switching to use the add/removeLanguageExtensions API call, once the clusters been created - so could we switch over to using that? That said this otherwise LGTM so if we can do that and the tests pass then this should otherwise be good to merge 👍
Thanks!
jrauschenbusch
force-pushed
the
r-kusto-cluster-language-extensions
branch
from
e90c427 to
45b94fd
Compare
jrauschenbusch
force-pushed
the
r-kusto-cluster-language-extensions
branch
from
142dda6 to
59a7f56
Compare
|
Hey @tombuildsstuff everything fixed now. Tests are running: ~ make acctests SERVICE='kusto' TESTARGS='-run=TestAccAzureRMKustoCluster_languageExtensions' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/kusto/tests/ -run=TestAccAzureRMKustoCluster_languageExtensions -timeout 60m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccAzureRMKustoCluster_languageExtensions
=== PAUSE TestAccAzureRMKustoCluster_languageExtensions
=== CONT TestAccAzureRMKustoCluster_languageExtensions
--- PASS: TestAccAzureRMKustoCluster_languageExtensions (2214.40s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/kusto/tests 2217.142s |
|
Hi @tombuildsstuff PR is now ready for a second review. |
katbyte
changed the title
|
This has been released in version 2.18.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.18.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Enhances the Kusto Cluster resource with the support for language extensions