-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource/data source azurerm_logic_app_integration_account
#7099
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @yupwei68. This is looking good! I just have a couple minor issues but once that's cleared up we should be good to go!
azurerm/internal/services/logic/logic_app_workflow_data_source.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/logic/tests/logic_app_workflow_resource_test.go
Outdated
Show resolved
Hide resolved
Hi @mbfrahry , thanks for your comments. Except one concern, changes have been pushed. Please continue reviewing. |
Hi @mbfrahry Please continue reviewing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I saw that this closed an issue. Will there be another PR for ISE as well? |
This has been released in version 2.17.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.17.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Partially fix: #2106
logic_app_work_flow integration test:
=== RUN TestAccAzureRMLogicAppWorkflow_integrationAccount
=== PAUSE TestAccAzureRMLogicAppWorkflow_integrationAccount
=== CONT TestAccAzureRMLogicAppWorkflow_integrationAccount
--- PASS: TestAccAzureRMLogicAppWorkflow_integrationAccount (196.99s)
resource test:
=== RUN TestAccAzureRMLogicAppIntegrationAccount_basic
=== PAUSE TestAccAzureRMLogicAppIntegrationAccount_basic
=== CONT TestAccAzureRMLogicAppIntegrationAccount_basic
--- PASS: TestAccAzureRMLogicAppIntegrationAccount_basic (94.94s)
=== RUN TestAccAzureRMLogicAppIntegrationAccount_requiresImport
=== PAUSE TestAccAzureRMLogicAppIntegrationAccount_requiresImport
=== CONT TestAccAzureRMLogicAppIntegrationAccount_requiresImport
--- PASS: TestAccAzureRMLogicAppIntegrationAccount_requiresImport (97.53s)
=== RUN TestAccAzureRMLogicAppIntegrationAccount_complete
=== PAUSE TestAccAzureRMLogicAppIntegrationAccount_complete
=== CONT TestAccAzureRMLogicAppIntegrationAccount_complete
--- PASS: TestAccAzureRMLogicAppIntegrationAccount_complete (96.88s)
=== RUN TestAccAzureRMLogicAppIntegrationAccount_update
=== PAUSE TestAccAzureRMLogicAppIntegrationAccount_update
=== CONT TestAccAzureRMLogicAppIntegrationAccount_update
--- PASS: TestAccAzureRMLogicAppIntegrationAccount_update (179.51s)
PASS
data source test:
=== RUN TestAccDataSourceAzureRMLogicAppIntegrationAccount_basic
=== PAUSE TestAccDataSourceAzureRMLogicAppIntegrationAccount_basic
=== CONT TestAccDataSourceAzureRMLogicAppIntegrationAccount_basic
--- PASS: TestAccDataSourceAzureRMLogicAppIntegrationAccount_basic (104.70s)
PASS