Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'azurerm_redis_cache' - Support for 'primary_connection_string' and 'secondary_connection_string' to 'resource_arm_redis_cache' #5958

Merged
merged 2 commits into from
Mar 4, 2020

Conversation

jackbatzner
Copy link
Contributor

Add support for primary_connection_string and secondary_connection_string to the Resource and Data Source for azurerm_redis_cache

Resource Acceptance Tests:
=== RUN TestAccDataSourceAzureRMRedisCache_standard
=== PAUSE TestAccDataSourceAzureRMRedisCache_standard
=== CONT TestAccDataSourceAzureRMRedisCache_standard
--- PASS: TestAccDataSourceAzureRMRedisCache_standard (2127.56s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/redis/tests 2127.824s

…ction_string' to 'resource_arm_redis_cache' resource and data source

Resource Acceptance Tests:
=== RUN   TestAccDataSourceAzureRMRedisCache_standard
=== PAUSE TestAccDataSourceAzureRMRedisCache_standard
=== CONT  TestAccDataSourceAzureRMRedisCache_standard
--- PASS: TestAccDataSourceAzureRMRedisCache_standard (2127.56s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/redis/tests 2127.824s
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Brunhil! LGTM 👍

@katbyte katbyte added this to the v2.1.0 milestone Mar 4, 2020
@katbyte katbyte merged commit 45857ef into hashicorp:master Mar 4, 2020
katbyte added a commit that referenced this pull request Mar 4, 2020
@ghost
Copy link

ghost commented Mar 11, 2020

This has been released in version 2.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.1.0"
}
# ... other configuration ...

@jackbatzner jackbatzner deleted the redis_connection_strings branch March 14, 2020 14:48
@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants