Bug: azurerm_frontdoor fix the way backend_pool_load_balancing/backend_pool_health_probe are saved to state file, exposed new attributes in backend_pool_health_probe block enabled and probe_method
#5924
Conversation
WodansSon
changed the title
azurerm_frontdoor fix the way backend_pool_load_balancing and backend_pool_health_probe are saved to state fileazurerm_frontdoor fix the way backend_pool_load_balancing/backend_pool_health_probe are saved to state file, expose new attribute to enable/disable backend_pool_health_probe
WodansSon
changed the title
azurerm_frontdoor fix the way backend_pool_load_balancing/backend_pool_health_probe are saved to state file, expose new attribute to enable/disable backend_pool_health_probeazurerm_frontdoor fix the way backend_pool_load_balancing/backend_pool_health_probe are saved to state file, exposed new attributes in backend_pool_health_probe block enabled and probe_method
| string(frontdoor.GET), | ||
| string(frontdoor.HEAD), | ||
| }, false), | ||
| Default: string(frontdoor.GET), |
There was a problem hiding this comment.
minor aesthetics/consistency, Could we put the default above validatefunc?
| @@ -870,6 +898,8 @@ func expandArmFrontDoorHealthProbeSettingsModel(input []interface{}, frontDoorPa | |||
| IntervalInSeconds: utils.Int32(intervalInSeconds), | |||
| Path: utils.String(path), | |||
| Protocol: frontdoor.Protocol(protocol), | |||
| HealthProbeMethod: healthProbeMethod, | |||
There was a problem hiding this comment.
I think you can just do
| HealthProbeMethod: healthProbeMethod, | |
| HealthProbeMethod: frontdoor.HealthProbeMethol(v ["probe_method"].(string)) |
?
There was a problem hiding this comment.
Yeah, should work... fixed.
| @@ -299,6 +309,69 @@ resource "azurerm_frontdoor" "test" { | |||
| `, data.RandomInteger, data.Locations.Primary, data.RandomInteger, data.RandomInteger) | |||
| } | |||
|
|
|||
| func testAccAzureRMFrontDoor_basicDisabled(data acceptance.TestData) string { | |||
| return fmt.Sprintf(` | |||
| resource "azurerm_resource_group" "test" { | |||
There was a problem hiding this comment.
can we add a provior block up here?
| func testAccAzureRMFrontDoor_basicDisabled(data acceptance.TestData) string { | ||
| return fmt.Sprintf(` | ||
| resource "azurerm_resource_group" "test" { | ||
| name = "acctestRG-%d" |
There was a problem hiding this comment.
Ad frontdoor here
| name = "acctestRG-%d" | |
| name = "acctestRG-frontdoor-%d" |
| } | ||
|
|
||
| resource "azurerm_frontdoor" "test" { | ||
| name = "acctestfd-%d" |
There was a problem hiding this comment.
uppercase where supported
| name = "acctestfd-%d" | |
| name = "acctest-FD-%d" |
|
|
|
This has been released in version 2.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.1.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Correcting a bug in the
backend_pool_load_balancingandbackend_pool_health_probeflatten function which showed false positives in the config -> state compare.(fixes #5499)
(fixes #5903)