Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_virtual_wan - support for the type property #5877

Merged
merged 1 commit into from
Feb 26, 2020
Merged

azurerm_virtual_wan - support for the type property #5877

merged 1 commit into from
Feb 26, 2020

Conversation

brent-au
Copy link
Contributor

This PR has been raised to add the ability to specify a 'type' for Azure Virtual WAN resources. Additional information concerning the different types can be found here: Basic and Standard Virtual WANs - Microsoft documentation.

I have added a type argument to the azurerm_virtual_wan resource and updated corresponding tests & documentation.

Manual testing with the existing behaviour indicates that Standard is now the default type, as opposed to Basic which was what I observed a few months ago.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @brent-au! LGTM

@katbyte katbyte changed the title Enhancement: Allow Virtual WAN type to be set azurerm_virtual_wan - allow type to be set Feb 26, 2020
@katbyte katbyte changed the title azurerm_virtual_wan - allow type to be set azurerm_virtual_wan - support for the type property Feb 26, 2020
@katbyte katbyte added this to the v2.1.0 milestone Feb 26, 2020
@katbyte katbyte merged commit 900f89c into hashicorp:master Feb 26, 2020
katbyte added a commit that referenced this pull request Feb 26, 2020
@ghost
Copy link

ghost commented Mar 11, 2020

This has been released in version 2.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.1.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants