azurerm_network_watcher_flow_log - support for theinterval_in_minutes property
#5851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
katbyte
requested changes
Mar 6, 2020
azurerm/internal/services/network/resource_arm_network_watcher_flow_log.go
Outdated
Show resolved
Hide resolved
| "interval": { | ||
| Type: schema.TypeInt, | ||
| Optional: true, | ||
| ValidateFunc: validation.IntAtMost(math.MaxInt32), |
There was a problem hiding this comment.
are negative values allowed?
Co-Authored-By: kt <[email protected]>
…_flow_log.go Co-Authored-By: kt <[email protected]>
Review [link](hashicorp#5851 (review))
katbyte
requested changes
Mar 9, 2020
| workspace_id = "${azurerm_log_analytics_workspace.test.workspace_id}" | ||
| workspace_region = "${azurerm_log_analytics_workspace.test.location}" | ||
| workspace_resource_id = "${azurerm_log_analytics_workspace.test.id}" | ||
| interval = 10 |
There was a problem hiding this comment.
This test will fail as this should be
Suggested change
| interval = 10 | |
| interval_in_minutes = 10 |
| resource.TestCheckResourceAttr(data.ResourceName, "enabled", "true"), | ||
| resource.TestCheckResourceAttr(data.ResourceName, "traffic_analytics.#", "1"), | ||
| resource.TestCheckResourceAttr(data.ResourceName, "traffic_analytics.0.enabled", "true"), | ||
| resource.TestCheckResourceAttr(data.ResourceName, "traffic_analytics.0.interval", "10"), |
katbyte
changed the title
interval for flow loginterval_in_minutes property
katbyte
force-pushed
the
flow_log_traffic_analytics_interval
branch
from
96dd1ef to
41263f9
Compare
katbyte
added a commit
that referenced
this pull request
Mar 9, 2020
r0bnet
pushed a commit
to r0bnet/terraform-provider-azurerm
that referenced
this pull request
Mar 9, 2020
…icorp#5851) This PR fix issue hashicorp#5830 Additionally, fix one bug of example in document, which lacks of specifying account_kind to StorageV2 (which defaults to v1) for storage account, which is required by azurerm_log_analytics_workspace.
r0bnet
pushed a commit
to r0bnet/terraform-provider-azurerm
that referenced
this pull request
Mar 9, 2020
|
This has been released in version 2.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.1.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix issue #5830
Additionally, fix one bug of example in document, which lacks of specifying
account_kindtoStorageV2(which defaults to v1) for storage account, which is required by azurerm_log_analytics_workspace.