Enhancement: azurerm_private_endpoint expose private_ip_address as computed attribute
#5838
Conversation
WodansSon
changed the title
private_ip_address for azurerm_private_endpoint azurerm_private_endpoint expose private_ip_address as computed attribute
| for _, item := range flattenedConnection { | ||
| v := item.(map[string]interface{}) | ||
| v["private_ip_address"] = privateIpAddress | ||
| } |
There was a problem hiding this comment.
I don't think you need to loop over the returned slice you just need to append the value to it if the privateIpAddress is not empty, something like the below... WDYT?
if privateIpAddress != "" {
privateIp := make(map[string]interface{})
privateIp["private_ip_address"] = privateIpAddress
flattenedConnection = append(flattenedConnection, privateIp)
}
There was a problem hiding this comment.
@WodansSon the flattenedConnection is a list of map, append it with another map will cause flattenedConnection has two maps, not a merged map.
There was a problem hiding this comment.
@njuCZ I got the iteration mixed up in my head... you're right... this is fine.
| for _, item := range flattenedConnection { | ||
| v := item.(map[string]interface{}) | ||
| v["private_ip_address"] = privateIpAddress | ||
| } |
There was a problem hiding this comment.
@njuCZ I got the iteration mixed up in my head... you're right... this is fine.
|
|
|
This has been released in version 2.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.1.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
fixes #5622
fixes #5208
add
private_ip_addressjust like data sourceazurerm_private_endpoint_connection.Because
azurerm_private_link_endpointuse the same flatten function, So I set this field outside this flatten function