Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apimanagement 2.0 todos and associated tests #5725

Merged
merged 6 commits into from
Feb 19, 2020

Conversation

jackofallops
Copy link
Member

@jackofallops jackofallops commented Feb 13, 2020

Fixes #5612

@jackofallops jackofallops added this to the v2.0.0 milestone Feb 13, 2020
@jackofallops jackofallops self-assigned this Feb 13, 2020
@ghost ghost added the size/XL label Feb 13, 2020
@jackofallops jackofallops force-pushed the f/two-oh-todo-apimanagement branch from 6fce3d9 to c803597 Compare February 13, 2020 14:48
@jackofallops jackofallops force-pushed the f/two-oh-todo-apimanagement branch from c803597 to 88ac09e Compare February 13, 2020 15:26
@jackofallops jackofallops requested a review from a team February 13, 2020 17:00
@jackofallops jackofallops marked this pull request as ready for review February 13, 2020 17:00
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor (non-blocking) thing but this otherwise LGTM 👍

@tombuildsstuff
Copy link
Contributor

Tests look good 👍

@jackofallops jackofallops merged commit c908fd4 into master Feb 19, 2020
@jackofallops jackofallops deleted the f/two-oh-todo-apimanagement branch February 19, 2020 10:29
tombuildsstuff added a commit that referenced this pull request Feb 19, 2020
@ghost
Copy link

ghost commented Feb 24, 2020

This has been released in version 2.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.0.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing SKU of existing azurerm_api_management has no effect
2 participants