Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notificationhub to 2.0 #5722

Merged
merged 4 commits into from
Feb 14, 2020
Merged

notificationhub to 2.0 #5722

merged 4 commits into from
Feb 14, 2020

Conversation

mbfrahry
Copy link
Member

No description provided.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor thing I'm going to push a commit for but this otherwise LGTM 👍

website/docs/r/notification_hub_namespace.html.markdown Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff added this to the v2.0.0 milestone Feb 13, 2020
@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2020-02-13 at 19 12 34

@tombuildsstuff tombuildsstuff merged commit 07a9cdb into master Feb 14, 2020
@tombuildsstuff tombuildsstuff deleted the notificationhub-2.0 branch February 14, 2020 07:45
tombuildsstuff added a commit that referenced this pull request Feb 14, 2020
@ghost
Copy link

ghost commented Feb 24, 2020

This has been released in version 2.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.0.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants