-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_sql_server: Enable SystemAssigned identity #4754
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @bgs113
Thanks for this PR - taking a look through this is looking good - if we can fix up the minor comments (and the tests pass) then this otherwise LGTM 👍
Thanks!
Addresses feedback from PR #4754: make all fields case sensitive, ensure identity block is always set, handle empty identity config
I updated the SQL Server data source to include the identity information. Let me know if you have any additional feedback or need anything else to move forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.37.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
This provides the capability to enable "SystemAssigned" identity on SQL Server resources, as in the following:
This is a prerequisite to enabling SQL TDE with BYOK using Azure Key Vault (requested in #87)