-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: Azure Data Explorer (kusto) #3856
Comments
Hey @subesokun, I'd suggest to split the data explorer into two resources:
Thanks in advance! |
Hi @r0bnet, splitting up the resources into |
Okay, then i'll propose a structure for both and probably one of the main contributors can review it. Most of the time you can get the information about what attributes are available from the ARM templates: https://docs.microsoft.com/de-de/azure/templates/microsoft.kusto/2019-01-21/clusters and https://docs.microsoft.com/de-de/azure/templates/microsoft.kusto/2019-01-21/clusters/databases |
My resource design proposal: Cluster: resource "azurerm_kusto_cluster" "cluster" {
name = "my-kusto-cluster"
resource_group_name = "my-kusto-rg"
location = "northeurope"
sku {
name = "Standard_D13_v2s" # required; possible values: Standard_D13_v2s, Standard_D14_v2s, Standard_L8s, Standard_L16s, Standard_D11_v2s, Standard_D12_v2s, Standard_L4s
capacity = 2 # required
}
tags = {
env = "PRODUCTION"
}
} Database: resource "azurerm_kusto_database" "database" {
name = "my-kusto-database"
resource_group_name = "my-kusto-rg"
location = "northeurope"
cluster_name = azurerm_kusto_cluster.cluster.name
soft_delete_period = "P365D" # optional
hot_cache_period = "P31D" # optional
} EventHub Data Connection: resource "azurerm_kusto_eventhub_data_connection" "eventhub" {
name = "my-kusto-database"
resource_group_name = "my-kusto-rg"
location = "northeurope"
cluster_name = azurerm_kusto_cluster.cluster.name
database_name = azurerm_kusto_cluster_database.database.name
eventhub_id = var.eventhub_id
consumer_group = var.consumer_group
table_name = "my-table"
mapping_rule_name = "MyMapping"
data_format = "JSON" // valid: 'MULTIJSON', 'JSON', 'CSV', 'TSV', 'SCSV', 'SOHSV', 'PSV', 'TXT', 'RAW', 'SINGLEJSON', 'AVRO'
} EventGrid Data Connection: resource "azurerm_kusto_eventgrid_data_connection" "eventhub" {
name = "my-kusto-database"
resource_group_name = "my-kusto-rg"
location = "northeurope"
cluster_name = azurerm_kusto_cluster.cluster.name
database_name = azurerm_kusto_cluster_database.database.name
storage_account_id = var.storage_account_id
eventhub_id = var.eventhub_id // should this be renamed to eventgrid_id?
consumer_group = var.consumer_group
table_name = "my-table"
mapping_rule_name = "MyMapping"
data_format = "JSON" // valid: 'MULTIJSON', 'JSON', 'CSV', 'TSV', 'SCSV', 'SOHSV', 'PSV', 'TXT', 'RAW', 'SINGLEJSON', 'AVRO'
} If i understood it correctly then |
Hi @r0bnet, the design looks good - a couple of comments:
|
|
Hi @r0bnet, maybe the following features could also be considered in your design:
|
@jrauschenbusch i updated my resource design above. Regarding the downside you mentioned i added a comment on that. Can you approve design and comment? |
Hi @r0bnet
The operation you're searching is
The design looks good to me. One question might be whether it is possible to establish a data connection before the table and table mapping exist. If not, then the ADX commands
As far as I understand, the eventhub_id property for the event grid data connection is not an error in their API. You can create an Event Grid subscription to a blob store in a storage account. The sink for such events must be one of the following types: Web Hook, Storage Queues, Event Hub, Hybrid Connections, or Service Bus Queue. Apparently, the only type currently supported by ADX data connections is an Event Hub sink.
Where did you get this information from? |
Some notes to the
|
I saw at least that |
True. I created an issue inside the Go SDK repo: Azure/azure-sdk-for-go#5558 Regarding the schema and mapping deployment: Do you think this should be realized via dedicated TF resource types or via scripts and a provisioner like |
I think you linked the wrong issue but found it anyway. The issues has to be addressed in a different repository as the sdk is autogenerated via this one: https://github.com/Azure/azure-rest-api-specs There the new API version (2019-05-15) should be added so that it will be added to the GO sdk later on. Regarding your other questions:
We faced similar situations for things like databases. Solution was to ONLY create real infrastructure in TF and leave the other stuff to development teams with their own tools. But also not ideal. |
@subesokun @r0bnet I think this ticket can now be closed. All resources listed here are now available. Support requests for new features of the specific resource types should be handled in dedicated tickets. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Community Note
Description
Request for new resource: Azure Data Explorer (kusto)
References
The text was updated successfully, but these errors were encountered: