Increase timeout for azurerm_app_service_plan to accommodate creation of Isolated SKUs that take a long time to provision

[nmiodice]

azurerm_app_service_plan resources that are created with an Isolated sku can take quite some time to create because they resources being created are not shared and take a long time to create within Azure itself.

This change increases the timeout to 3 hours when creating azurerm_app_service_plan resources. This covers nearly all of the scenarios, as most will create in <= 1.5 hours.

Note: I'm aware that this will be fixed by #171 but I thought that since this is an expected scenario that we should fix it up front

[katbyte]

Hi @nmiodice,

Thanks for the PR. Upon internal discussion we decided it would be best to just updated the global default to 3 hours as there are some other resources that also are hitting timeouts. This should hold us over until we can properly thread in context/timeouts through all resources.

I hope you don't mind but i pushed those changes so we could get this merged 🙂

[nmiodice]

Thanks @katbyte -- one question, this change looks slated for 1.31.0 which is unreleased according to https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/CHANGELOG.md. When will this actually release? What controls this release and how is the cadence set?

[ghost]

This has been released in version 1.31.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.31.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!