[azurerm_iothub] - support for the file_upload property

[jhosteny]

Fixes #2948.

Remarks

This PR adds support for file uploads and notifications to IoT Hub.

Example

resource "azurerm_resource_group" "test" {    
  name     = "resourceGroup1"    
  location = "West US"    
}    
      
resource "azurerm_storage_account" "test" {    
  name                     = "teststa"    
  resource_group_name      = "${azurerm_resource_group.test.name}"    
  location                 = "${azurerm_resource_group.test.location}"    
  account_tier             = "Standard"    
  account_replication_type = "LRS"    
}    
      
resource "azurerm_storage_container" "test" {    
  name                  = "test"    
  resource_group_name   = "${azurerm_resource_group.test.name}"    
  storage_account_name  = "${azurerm_storage_account.test.name}"    
  container_access_type = "private"    
}

resource "azurerm_iothub" "test" {    
  name                = "test"
  resource_group_name = "${azurerm_resource_group.test.name}"
  location            = "${azurerm_resource_group.test.location}"                                                                                                                                  
  sku {    
    name     = "S1"
    tier     = "Standard"
    capacity = "1"       
  }

  file_upload {
    connection_string  = "${azurerm_storage_account.test.primary_blob_connection_string}"
    container_name     = "${azurerm_storage_container.test.name}"
    sas_ttl            = "PT1H"
    notifications      = true
    lock_duration      = "PT1M"
    default_ttl        = "PT1H"
    max_delivery_count = 10
  }
}

Acceptance Tests

]$ make testacc TESTARGS='-run=TestAccAzureRMIotHub'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor'|grep -v 'examples') -v -run=TestAccAzureRMIotHub -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
?   	github.com/terraform-providers/terraform-provider-azurerm	[no test files]
=== RUN   TestAccAzureRMIotHubConsumerGroup_events
=== PAUSE TestAccAzureRMIotHubConsumerGroup_events
=== RUN   TestAccAzureRMIotHubConsumerGroup_requiresImport
--- SKIP: TestAccAzureRMIotHubConsumerGroup_requiresImport (0.00s)
	resource_arm_iothub_consumer_group_test.go:41: Skipping since resources aren't required to be imported
=== RUN   TestAccAzureRMIotHubConsumerGroup_operationsMonitoringEvents
=== PAUSE TestAccAzureRMIotHubConsumerGroup_operationsMonitoringEvents
=== RUN   TestAccAzureRMIotHubSharedAccessPolicy_basic
=== PAUSE TestAccAzureRMIotHubSharedAccessPolicy_basic
=== RUN   TestAccAzureRMIotHubSharedAccessPolicy_writeWithoutRead
=== PAUSE TestAccAzureRMIotHubSharedAccessPolicy_writeWithoutRead
=== RUN   TestAccAzureRMIotHubSharedAccessPolicy_requiresImport
--- SKIP: TestAccAzureRMIotHubSharedAccessPolicy_requiresImport (0.00s)
	resource_arm_iothub_shared_access_policy_test.go:63: Skipping since resources aren't required to be imported
=== RUN   TestAccAzureRMIotHub_basic
=== PAUSE TestAccAzureRMIotHub_basic
=== RUN   TestAccAzureRMIotHub_ipFilterRules
=== PAUSE TestAccAzureRMIotHub_ipFilterRules
=== RUN   TestAccAzureRMIotHub_requiresImport
--- SKIP: TestAccAzureRMIotHub_requiresImport (0.00s)
	resource_arm_iothub_test.go:64: Skipping since resources aren't required to be imported
=== RUN   TestAccAzureRMIotHub_standard
=== PAUSE TestAccAzureRMIotHub_standard
=== RUN   TestAccAzureRMIotHub_customRoutes
=== PAUSE TestAccAzureRMIotHub_customRoutes
=== RUN   TestAccAzureRMIotHub_fileUpload
=== PAUSE TestAccAzureRMIotHub_fileUpload
=== RUN   TestAccAzureRMIotHub_fallbackRoute
=== PAUSE TestAccAzureRMIotHub_fallbackRoute
=== CONT  TestAccAzureRMIotHubConsumerGroup_events
=== CONT  TestAccAzureRMIotHub_standard
=== CONT  TestAccAzureRMIotHub_ipFilterRules
=== CONT  TestAccAzureRMIotHub_fileUpload
=== CONT  TestAccAzureRMIotHub_customRoutes
=== CONT  TestAccAzureRMIotHubSharedAccessPolicy_writeWithoutRead
=== CONT  TestAccAzureRMIotHub_fallbackRoute
=== CONT  TestAccAzureRMIotHubSharedAccessPolicy_basic
--- PASS: TestAccAzureRMIotHubSharedAccessPolicy_writeWithoutRead (4.57s)
=== CONT  TestAccAzureRMIotHubConsumerGroup_operationsMonitoringEvents
--- PASS: TestAccAzureRMIotHub_ipFilterRules (390.99s)
=== CONT  TestAccAzureRMIotHub_basic
--- PASS: TestAccAzureRMIotHub_fallbackRoute (450.21s)
--- PASS: TestAccAzureRMIotHubConsumerGroup_events (470.32s)
--- PASS: TestAccAzureRMIotHub_customRoutes (597.95s)
--- PASS: TestAccAzureRMIotHub_basic (443.31s)
--- PASS: TestAccAzureRMIotHub_standard (864.37s)
--- PASS: TestAccAzureRMIotHub_fileUpload (955.01s)
--- PASS: TestAccAzureRMIotHubConsumerGroup_operationsMonitoringEvents (950.62s)
--- PASS: TestAccAzureRMIotHubSharedAccessPolicy_basic (1067.35s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	1067.379s

[tombuildsstuff]

hey @jhosteny

Thanks for this PR :)

Taking a look through this if we can add a nil-check to the flatten function (to catch a potential crash) this otherwise LGTM 👍

Thanks!

[ghost]

This has been released in version 1.32.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.32.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!