Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: azurerm_api_management_backend #3676

Merged
merged 17 commits into from
Jul 6, 2019

Conversation

hbuckle
Copy link
Contributor

@hbuckle hbuckle commented Jun 16, 2019

Adds a new resource for configuring API manager backends.
The header and query properties of the credentials block are both maps with values that are lists of strings, but schema.TypeMap only accepts primitive types for values so I'm not sure how to represent these properties.

@hbuckle
Copy link
Contributor Author

hbuckle commented Jun 27, 2019

Any chance someone could take a look at this one?

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hbuckle,

Sorry for the delay, we've been slowly working through the backlog here. Overall this LGTM with one very minor stylistic comment.

As for the TypeMap situation here i think your best bet is to do a ; separated (or other value that would work with the data) string list. Its not ideal but i think its the old reasonable way forward. WDYT?

Once those properties are implemented and the tests pass this should be good to merge 🙂

azurerm/resource_arm_api_management_backend.go Outdated Show resolved Hide resolved
@hbuckle
Copy link
Contributor Author

hbuckle commented Jul 5, 2019

@katbyte - thanks for the review. I've implemented header and query as a comma separated string as suggested

@ghost ghost removed the waiting-response label Jul 5, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the revisions @hbuckle, LGTM now 🙂

@katbyte katbyte added this to the v1.32.0 milestone Jul 6, 2019
@katbyte katbyte merged commit 114ecfd into hashicorp:master Jul 6, 2019
katbyte added a commit that referenced this pull request Jul 6, 2019
@ghost
Copy link

ghost commented Jul 30, 2019

This has been released in version 1.32.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.32.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants