-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource: azurerm_api_management_backend #3676
Conversation
Any chance someone could take a look at this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hbuckle,
Sorry for the delay, we've been slowly working through the backlog here. Overall this LGTM with one very minor stylistic comment.
As for the TypeMap situation here i think your best bet is to do a ;
separated (or other value that would work with the data) string list. Its not ideal but i think its the old reasonable way forward. WDYT?
Once those properties are implemented and the tests pass this should be good to merge 🙂
@katbyte - thanks for the review. I've implemented header and query as a comma separated string as suggested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the revisions @hbuckle, LGTM now 🙂
This has been released in version 1.32.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.32.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Adds a new resource for configuring API manager backends.
The
header
andquery
properties of thecredentials
block are both maps with values that are lists of strings, but schema.TypeMap only accepts primitive types for values so I'm not sure how to represent these properties.